wip: router changes to allow method-not-allowed#2067
Draft
Conversation
add tests for - GET /login to return 405 Method Not Allowed - POST /login to return 401 Unauthorized if auth header not present initial work on getting router to find path-but-not-method matches hampered by the `GET /:cid` route matching `GET /login` see #2066 License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <oli@tableflip.io>
Deploying with
|
| Latest commit: |
e04cc59
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://18158d07.nft-storage-1at.pages.dev |
| Branch Preview URL: | https://method-not-allowed.nft-storage-1at.pages.dev |
alanshaw
reviewed
Jul 18, 2022
| r.add('get', '/check/:cid', withMode(nftCheck, RO), [postCors]) | ||
| r.add('get', '', withAuth(withMode(nftList, RO)), [postCors]) | ||
| r.add('get', '/:cid', withAuth(withMode(nftGet, RO)), [postCors]) | ||
| r.add('get', /^\/(?<cid>ba\S+|Qm\S+)/i, withAuth(withMode(nftGet, RO)), [ |
Contributor
There was a problem hiding this comment.
What if we added:
r.add('get', '/login', () => new Response({ status: 405, statusText: 'Method Not Allowed' }), [postCors])
r.add('get', '/:cid', withAuth(withMode(nftGet, RO)), [postCors])- No regex
- Allows other multibases to be supported if we want
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add tests for
initial work on getting router to find path-but-not-method matches
hampered by the
GET /:cidroute matchingGET /loginsee #2066
License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans oli@tableflip.io