feat: restrict in flight psa requests with max quota#1974
Open
vasco-santos wants to merge 1 commit intomainfrom
Open
feat: restrict in flight psa requests with max quota#1974vasco-santos wants to merge 1 commit intomainfrom
vasco-santos wants to merge 1 commit intomainfrom
Conversation
Deploying with
|
| Latest commit: |
4393c43
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db75466b.nft-storage-1at.pages.dev |
| Branch Preview URL: | https://feat-restrict--in-flight-psq.nft-storage-1at.pages.dev |
vasco-santos
force-pushed
the
feat/restrict/-in-flight-psq-requests-with-max-quota
branch
from
c784e9c to
4393c43
Compare
alanshaw
reviewed
Jun 13, 2022
Contributor
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
The issue is that pin status is updated asynchronously every 10 minutes, so folks might reach their quota quickly and then have to wait a long time to continue...
Contributor
Author
Should we look for Pins created older than 10 minutes to start with? I think there is no great solution for this while we have Pin Status as is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a route middleware to routes POST /pins and /pins/:requestId, augmenting the authorization layer to also check the on going requests. We also have a ENV var that we can add to override the current default of 100 in flight requests.
100 was chosen arbitrarily given I don't have any nice metrics to get a better number, so open for suggestions here.
Closes #1870