Skip to content

Improve birth date #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrcaseb merged 3 commits into from
Oct 4, 2026
Merged

Improve birth date #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0a29fe
Use mode of birth dates across roster seasons
mrcaseb Oct 4, 2026
41c6fde
version bump
mrcaseb Oct 4, 2026
d84f3eb
clean overwrite
mrcaseb Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: nflverse.players
Title: Create 'nflverse' Players Data
Version: 0.1.6
Version: 0.1.7
Authors@R: c(
person("Sebastian", "Carl", , "mrcaseb@gmail.com", role = c("aut", "cre")),
person("Tan", "Ho", , "tan@tanho.ca", role = "aut",
Expand Down
8 changes: 7 additions & 1 deletion R/players_basis.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@ players_basis_release <- function(overwrite = !interactive()){
player_gsis_id = dplyr::if_else(is.na(player_gsis_id), player_esb_id, player_gsis_id)
) |>
dplyr::filter(!is.na(player_gsis_id)) |>
dplyr::mutate(rookie_season = dplyr::first(season), .by = player_gsis_id) |>
dplyr::mutate(
rookie_season = dplyr::first(season),
# we saw some rare problems where the birth date of the final season
# was wrong (#26). That's why we use mode on birth date here.
player_birth_date = nflreadr::stat_mode(player_birth_date, na.rm = TRUE),
.by = player_gsis_id
) |>
dplyr::slice_max(tibble::tibble(season, dplyr::desc(player_status)), n = 1, by = player_gsis_id) |>
dplyr::mutate_if(is.list, ~ purrr::map_chr(.x, ~ unlist(.x) |> paste(collapse = "; "))) |>
dplyr::rename_with(~ gsub("player_", "", .x)) |>
Expand Down
16 changes: 0 additions & 16 deletions inst/players_manual_overwrite.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@
"gsis_id": "00-0041026",
"espn_id": "4685248"
},
{
"gsis_id": "00-0040897",
"pfr_id": "MorrMi02"
},
{
"gsis_id": "00-0040878",
"espn_id": "4686658"
Expand Down Expand Up @@ -135,10 +131,6 @@
"gsis_id": "00-0040750",
"pff_id": "103620"
},
{
"gsis_id": "00-0040745",
"pff_id": "129649"
},
{
"gsis_id": "00-0040740",
"pff_id": "123552"
Expand All @@ -147,14 +139,6 @@
"gsis_id": "00-0040732",
"pff_id": "146969"
},
{
"gsis_id": "00-0040728",
"pff_id": "124034"
},
{
"gsis_id": "00-0040726",
"pff_id": "143985"
},
{
"gsis_id": "00-0040717",
"pff_id": "104700"
Expand Down
Loading