Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Add hint to solve git errors with a synced repo #3279

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

mirpedrol
Copy link
Member

Close #3263

log.error(
f"Could not check out commit '{commit}' in '{self.remote_url}'.\n"
"To solve this, you can try to remove the cloned rempository and run the command again."
f"This repository is tipically found at `~/.config/nfcore/{self.local_repo_dir}`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f"This repository is tipically found at `~/.config/nfcore/{self.local_repo_dir}`"
f"This repository is found at `{Path(self.local_repo_dir).absolute()}`"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this 🤔 Do you know how could we test it? how to create a corrupted repo so that we can see this message

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, just put something in your ~/.config/nfcore/modules directory

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok tested :) it was already an absolute path so we can use it as it is. thanks!

nf_core/synced_repo.py Outdated Show resolved Hide resolved
nf_core/synced_repo.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.70%. Comparing base (24e2dc2) to head (db11da5).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/synced_repo.py 50.00% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol merged commit 0848508 into nf-core:dev Nov 14, 2024
84 checks passed
@mirpedrol mirpedrol deleted the fix_3263 branch November 14, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants