-
Notifications
You must be signed in to change notification settings - Fork 35
Added optional Bwa index parameter to skip bwamem2 index for a faster output #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
682576d
7b44c68
9fa9923
582938f
4576ce3
3218dc2
59e6b2b
01fd46a
f03a1da
c3d3498
8cdf2fd
d765d1d
884cb2a
d0141fb
6b8c76e
0cfcb83
db7395a
7135a9d
5d129cf
4117e63
c7867ab
b8b638f
16cad1b
f96e208
c11a49d
567a431
8a20d2d
d5ae511
6417907
257ff2d
8527ccd
d23962a
5eeac1a
2b6c91d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why a separate file for this, and not using the |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| process { | ||
|
|
||
|
|
||
| // TODO nf-core: Check the defaults for all processes | ||
| cpus = { 1 * task.attempt } | ||
| memory = { 6.GB * task.attempt } | ||
| time = { 4.h * task.attempt } | ||
|
|
||
| errorStrategy = { task.exitStatus in ((130..145) + 104) ? 'retry' : 'finish' } | ||
| maxRetries = 2 | ||
| maxErrors = '-1' | ||
|
|
||
|
|
||
| // Subsampling reads | ||
| withName: 'SEQTK_SAMPLE' { | ||
| cpus = 6 | ||
| memory = { 4.GB * task.attempt } | ||
| time = { 4.h * task.attempt } | ||
| } | ||
|
|
||
| // Quality control | ||
| withName: 'FASTQC' { | ||
| cpus = 2 | ||
| memory = { 36.GB * task.attempt } | ||
| time = { 8.h * task.attempt } | ||
| } | ||
| withName: 'SEQFU_STATS' { | ||
| cpus = 6 | ||
| memory = { 4.GB * task.attempt } | ||
| time = { 4.h * task.attempt } | ||
| } | ||
| withName: 'FASTQSCREEN_FASTQSCREEN' { | ||
| cpus = 6 | ||
| memory = { 36.GB * task.attempt } | ||
| time = { 8.h * task.attempt } | ||
| } | ||
|
|
||
| // Reference genome processing | ||
| withName: 'BWAMEM2_INDEX' { | ||
| cpus = 12 | ||
| memory = { 72.GB * task.attempt } | ||
| time = { 16.h * task.attempt } | ||
| } | ||
| withName: 'BWAMEM2_MEM' { | ||
| cpus = 6 | ||
| memory = { 35.GB * task.attempt } | ||
| time = { 16.h * task.attempt } | ||
| } | ||
| withName: 'SAMTOOLS_INDEX' { | ||
| cpus = 6 | ||
| memory = { 4.GB * task.attempt } | ||
| time = { 4.h * task.attempt } | ||
| } | ||
| withName: 'SAMTOOLS_FAIDX' { | ||
| cpus = 6 | ||
| memory = { 6.GB * task.attempt } | ||
| time = { 4.h * task.attempt } | ||
| } | ||
| // Picard metrics | ||
| withName: 'PICARD_COLLECTMULTIPLEMETRICS' { | ||
| cpus = 4 | ||
| memory = { 8.GB * task.attempt } | ||
| time = { 4.h * task.attempt } | ||
| } | ||
|
|
||
| // MultiQC aggregation | ||
| withName: 'MULTIQC_GLOBAL|MULTIQC_PER_TAG' { | ||
| cpus = 4 | ||
| memory = { 4.GB * task.attempt } | ||
| time = { 4.h * task.attempt } | ||
| } | ||
| } |
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so for me bwa and other indexes should be fetch using getGenomeAttribute at this level from the igenomes.config file around L17 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ params { | |
| igenomes_base = 's3://ngi-igenomes/igenomes/' | ||
| igenomes_ignore = false | ||
| sort_bam = true | ||
| bwa_index = null | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that should not be needed |
||
|
|
||
| // Fastqscreen options | ||
| fastq_screen_references = "${projectDir}/assets/example_fastq_screen_references.csv" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -214,7 +214,8 @@ | |
| "modules_testdata_base_path": { | ||
| "type": "string", | ||
| "description": "Base path / URL for data used in the modules", | ||
| "hidden": true | ||
| "hidden": true, | ||
| "default": "s3://ngi-igenomes/testdata/nf-core/modules/" | ||
| }, | ||
| "multiqc_config": { | ||
| "type": "string", | ||
|
|
@@ -282,5 +283,10 @@ | |
| { | ||
| "$ref": "#/$defs/generic_options" | ||
| } | ||
| ] | ||
| ], | ||
| "properties": { | ||
| "bwa_index": { | ||
| "type": "string" | ||
| } | ||
| } | ||
|
Comment on lines
+287
to
+291
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that should be in the |
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is 132?