Skip to content

correcting multicycle test cases and checking on validation#74

Open
RobJY wants to merge 2 commits into
nf-core:devfrom
RobJY:bugfix_multi_cycle_test
Open

correcting multicycle test cases and checking on validation#74
RobJY wants to merge 2 commits into
nf-core:devfrom
RobJY:bugfix_multi_cycle_test

Conversation

@RobJY
Copy link
Copy Markdown
Contributor

@RobJY RobJY commented Jan 17, 2025

I think I had errors in the multicycle test cases and this should correct them.
I made this PR to see how these updated tests work with our CI tests.
I'm concerned that the CI tests didn't catch this because the validation does throw an error when run manually, so I'm looking into it.
To be clear, the test suite doesn't catch this when run manually, but if I run the workflow manually outside the test suite the validation we have does throw an error.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).

@RobJY RobJY self-assigned this Jan 17, 2025
@lpantano
Copy link
Copy Markdown

lpantano commented Mar 5, 2026

@RobJY do you want to try to fix conflict and as for a reviewer for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants