fix(storybook): add base tag for /ui subpath URL resolution#12
Merged
bob-obringer merged 1 commit intomainfrom Jan 13, 2026
Merged
fix(storybook): add base tag for /ui subpath URL resolution#12bob-obringer merged 1 commit intomainfrom
bob-obringer merged 1 commit intomainfrom
Conversation
The viteFinal config alone wasn't sufficient for subpath deployment. Added <base href="/ui/"> to both manager-head.html and preview-head.html to ensure all relative URLs resolve correctly. Also fixed favicon path to be relative (works with base tag). Fixes NEYN-8505 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<base href="/ui/">tomanager-head.htmlandpreview-head.htmlThe
viteFinalconfig from PR #11 wasn't sufficient - the browser was still resolving relative URLs from the root instead of/ui/. The<base>tag fixes this.Test plan
Fixes NEYN-8505
🤖 Generated with Claude Code