feat(amr): forward AMR_CLIENT_SOURCE to vela + source on wallet links by lefarcen · Pull Request #4005 · nexu-io/open-design

lefarcen · 2026-06-09T13:35:31Z

背景

配合 vela 的「按宿主产品区分收入来源」改动（powerformer/vela#270）。让 vela CLI 把 Open Design 拉起的命令 + 模型调用归因为 source=open_design。

改动（已随 main 收敛）

runtimes/env.ts：AMR agent spawn 时设 AMR_CLIENT_SOURCE=open_design（紧随 main 的 amrAnalyticsIdentityEnv 之后）。非 PII，不走 telemetry consent 门控。
amr-guidance.ts：AMR 钱包/console URL（prod/test/local 各 profile）加 ?source=open_design，供 vela web 的 page_view 归因。
vela-errors.ts：daemon 错误卡的充值链接同样加 ?source=open_design。

OD_INSTALLATION_ID 的转发已由 main 的 amrAnalyticsIdentityEnv（consent-gated，覆盖所有 AMR spawn）实现，故本 PR 早先的 spawnVelaLogin 改动已移除（冗余）。

待 vela 发版后的follow-up

本改动设的 AMR_CLIENT_SOURCE 需要新版 vela CLI才会被读取并注入网关 header。vela#270 合并发版后，需把 OD 打包的 vela 二进制升级到新版，收入归因才端到端生效。

测试

@open-design/daemon typecheck 通过（仅本地缺 node-pty 原生依赖的无关报错）。

🤖 Generated with Claude Code

…allet links So vela analytics can attribute Open Design's command funnel and model spend back to this host (source=open_design), and the AMR wallet landing carries the source for the web page_view. - runtimes/env: set AMR_CLIENT_SOURCE=open_design for the amr agent spawn (not PII, so no telemetry-consent gate) - integrations/vela: spawnVelaLogin forwards OD_INSTALLATION_ID (consent-gated) - web/daemon: AMR wallet recharge URL gains ?source=open_design Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

PerishCode · 2026-06-09T13:41:42Z

@lefarcen I'm holding off on generating review comments for #4005 because this pull request has merge conflicts right now.

Please resolve the conflicts with main and push the updated branch. Once that's done, request or wait for the review to run again and I'll take another look.

_{🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.}

…-redirect # Conflicts: # apps/daemon/src/integrations/vela.ts # apps/daemon/src/runtimes/env.ts # apps/daemon/src/server.ts # apps/web/src/runtime/amr-guidance.ts

github-actions · 2026-06-09T15:06:40Z

Visual regression review

Head: 5d56c77 · Base: c2d1672

14 changed · 21 unchanged · 0 missing baseline · 0 failed

Changed cases

Case	Main	PR	Diff
visual-avatar-local-agent-list
visual-avatar-menu
visual-home-plugin-use-with-query
visual-plugin-details
visual-plugin-share-menu
visual-project-avatar-model-dropdown
visual-project-workspace
visual-settings-byok
visual-settings-byok-model-dropdown
visual-settings-byok-openai
visual-settings-execution
visual-settings-local-cli
visual-settings-local-cli-model-dropdown
visual-workspace-staged-contexts

Unchanged cases

Case	Main	PR	Diff
visual-design-system-detail
visual-design-systems
visual-home
visual-home-catalog
visual-home-context-picker
visual-home-plugin-filter
visual-home-plugin-use-staged
visual-home-staged-attachment
visual-integrations
visual-integrations-mcp
visual-integrations-use-everywhere
visual-new-project-modal
visual-onboarding-runtime
visual-plugins
visual-projects
visual-projects-kanban
visual-tasks
visual-topbar-byok-model-dropdown
visual-topbar-byok-switcher
visual-topbar-execution-switcher

Visual diff is advisory only and does not block merging.

The AMR console/recharge links the OD app opens into vela web now carry ?source=open_design so vela attributes the visit to Open Design. Update the console/recharge URL assertions accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…recharge URL DEFAULT_AMR_RECHARGE_URL now carries the source param for attribution. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

lefarcen

The ## 背景 / ## 改动 / ## 测试 sections cover the background, change scope, and validation well — the note about _redirects not changing (to avoid mis-attribution on social-auth callback) is especially helpful context.

One quick addition: could you fill in a ## Surface area checklist? This PR introduces an env var (AMR_CLIENT_SOURCE), changes vela CLI attribution behaviour, and appends ?source=open_design to wallet links — ticking the relevant boxes (e.g. Env var, Default behavior change) would let reviewers scope the blast radius in one glance.

mrcfps

@lefarcen Thanks for wiring the AMR source attribution through both the CLI env and the wallet links. I found one blocking follow-up before this is ready: the recharge URL changed in production code, but the end-to-end insufficient-balance coverage is still pinned to the old URL, so this path will go red as soon as that suite runs.

_{🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.}

…sertion - tools/pack: bundle @powerformer/vela-cli 0.0.15 (the release carrying the source-attribution logic that reads AMR_CLIENT_SOURCE and tags model_request) - e2e: expect the insufficient-balance recharge URL to carry ?source=open_design (addresses review on DEFAULT_AMR_RECHARGE_URL) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

The tools/pack @powerformer/vela-cli bump changed pnpm-lock.yaml, invalidating the daemon/web fetchPnpmDeps fixed-output hashes. Update to the values the Nix flake check computed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

github-actions · 2026-06-10T01:47:51Z

🚀 Landing page preview

This PR is deployed to a Cloudflare Pages preview — not staging or production:

Stable alias: https://pr-4005.open-design-landing-staging.pages.dev
This build: https://93d1ad3e.open-design-landing-staging.pages.dev
Updated for commit 5d56c77.

mrcfps

@lefarcen I re-reviewed the updated head and didn't find any remaining actionable issues in the changed ranges. The AMR source tagging is threaded consistently through the daemon spawn env, the wallet/console URLs for the relevant profiles, and the packaged vela CLI bump is paired with the lockfile/Nix hash refresh. Thanks for tightening up the follow-up fixes here.

_{🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.}

lefarcen and others added 2 commits June 1, 2026 18:32

fix(landing): keep auth redirects on AMR wallet

dc75b71

Merge remote-tracking branch 'origin/main' into codex/amr-wallet-auth…

26f5b73

…-redirect # Conflicts: # apps/daemon/src/integrations/vela.ts # apps/daemon/src/runtimes/env.ts # apps/daemon/src/server.ts # apps/web/src/runtime/amr-guidance.ts

audit and others added 2 commits June 9, 2026 23:31

test(daemon): expect ?source=open_design on AMR insufficient-balance …

44a2eeb

…recharge URL DEFAULT_AMR_RECHARGE_URL now carries the source param for attribution. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

lefarcen requested a review from mrcfps June 9, 2026 16:03

lefarcen added size/S PR changes 20-100 lines risk/high High risk: apps/desktop, daemon, auth, migration, workflows, package deps type/feature New feature labels Jun 9, 2026

lefarcen commented Jun 9, 2026

View reviewed changes

mrcfps requested changes Jun 9, 2026

View reviewed changes

Comment thread apps/daemon/src/integrations/vela-errors.ts

lefarcen requested a review from a team as a code owner June 10, 2026 01:42

lefarcen added size/M PR changes 100-300 lines and removed size/S PR changes 20-100 lines labels Jun 10, 2026

mrcfps approved these changes Jun 10, 2026

View reviewed changes

lefarcen added this pull request to the merge queue Jun 10, 2026

Merged via the queue into main with commit 3f5fe0f Jun 10, 2026
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(amr): forward AMR_CLIENT_SOURCE to vela + source on wallet links#4005

feat(amr): forward AMR_CLIENT_SOURCE to vela + source on wallet links#4005
lefarcen merged 7 commits into
mainfrom
codex/amr-wallet-auth-redirect

lefarcen commented Jun 9, 2026 •

edited

Loading

Uh oh!

PerishCode commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

lefarcen left a comment

Uh oh!

mrcfps left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 10, 2026 •

edited

Loading

Uh oh!

mrcfps left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

lefarcen commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

背景

改动（已随 main 收敛）

待 vela 发版后的follow-up

测试

Uh oh!

PerishCode commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual regression review

Changed cases

Uh oh!

lefarcen left a comment

Choose a reason for hiding this comment

Uh oh!

mrcfps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Landing page preview

Uh oh!

mrcfps left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lefarcen commented Jun 9, 2026 •

edited

Loading

github-actions Bot commented Jun 9, 2026 •

edited

Loading

github-actions Bot commented Jun 10, 2026 •

edited

Loading