fix: prevent horizontal overflow on home page#3944
Open
Kushaal-k wants to merge 1 commit into
Open
Conversation
Contributor
Contributor
Author
|
Hey @lefarcen, can you check if this fixes the issue? |
lefarcen
reviewed
Jun 9, 2026
lefarcen
left a comment
Contributor
There was a problem hiding this comment.
Hey @Kushaal-k — yes, this fixes it! 👋
The one-liner is exactly right. A few notes on why the approach is solid:
clipoverhiddenis the precise call here.overflow-x: hiddenwould establish a new horizontal scroll origin on.entry-main--scroll, which can silently breakposition: stickydescendants — and this scroll container already has a sticky topbar (.entry-main__topbarat line 742).clipcuts the overflow without creating that side-effect, so sticky continues to work correctly.- The fix targets the root cause at the right layer (the scroll container itself) rather than chasing individual overflowing descendants.
- PR body is thorough — the Why/What/Validation writeup maps cleanly to the issue.
CI is all green and the strict visual regression check passed with 4 changed cases (all expected — the horizontal leak is gone). Clean from my side. ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
















































Fixes #3910
Why
This PR addresses a layout regression on the Home page where a spurious horizontal scrollbar appears at the bottom of the window, even though the content already fits within the available viewport.
The root scroller (
.entry-main--scroll) was missing anoverflow-xguard. Because of this, any descendant elements that marginally exceeded the 1440px cap—such as100vwbackgrounds, max-content rows, or chip strips with horizontal overflow—caused the entire page layout to leak out and expose a bottom scrollbar. Addingoverflow-x: clipprevents the leak while preservingposition: stickychild elements like the topbar.What users will see
Users will no longer see a spurious horizontal scrollbar at the bottom of the Home page, restoring a stable and visually polished layout that is locked horizontally.
Surface area
apps/weborapps/desktop(including Electron menu bar)odsubcommand or flag, newtools-dev/tools-pack/tools-prflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates/, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.json(dependenciesordevDependencies); workspace-packagepackage.jsonfiles are out of scope. Include a paragraph on what we get vs. what bytes we ship (seeCONTRIBUTING.md→ Code style)Screenshots
Bug fix verification
mainand green on this branch? (yes / no): N/Aoverflow-x: clip;) to bound the horizontal width of.entry-main--scroll. Tested visually in the browser across viewport bounds above and below the inner max-width breakpoint to ensure horizontal scroll leak is patched without breaking the sticky layout logic.Validation
pnpm tools-devand performed a visual verification of the Home page layout ensuring the horizontal scrollbar is permanently removed and the topbar remains correctly positioned.pnpm guard+pnpm typecheckpnpm --filter @open-design/web test