chore: finish slimclaw runtime convergence#1087
Conversation
docs: add slimclaw runtime unification plan
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac091c3438
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return { | ||
| command: runtime.binPath, | ||
| argsPrefix: [], |
There was a problem hiding this comment.
Restore fallback when OPENCLAW_BIN is not resolvable
getOpenClawCommandSpec now always executes runtime.binPath directly, but in the tools/dev flow the controller environment does not set OPENCLAW_BIN (so it defaults to "openclaw"), and there is no guaranteed global openclaw binary. That makes ModelProviderService.execOpenClawCommand() fail with ENOENT when MiniMax OAuth tries to run plugins enable, blocking that user flow even though the repo-local runtime exists. The previous logic handled this by resolving a workspace runtime entry/wrapper when OPENCLAW_BIN was just a command name.
Useful? React with 👍 / 👎.
Deploying nexu-docs with
|
| Latest commit: |
68af6bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4e43941.nexu-docs.pages.dev |
| Branch Preview URL: | https://feat-openclaw-runtime-optimi.nexu-docs.pages.dev |
What
Converges repo-local OpenClaw runtime ownership behind
packages/slimclaw, migrates the local dev CLI intotools/dev, and removes the controller-side fallback that was duplicating slimclaw runtime assets into the Windows desktop package.Why
This branch finishes the runtime-boundary cleanup needed to keep desktop/dev flows controller-first while shrinking packaging risk and clarifying runtime ownership. It also fixes the Windows installer bloat caused by the controller sidecar carrying a full slimclaw runtime payload instead of relying on desktop/dev launcher injection.
How
packages/slimclawpnpm devimplementation fromscripts/devtotools/devand hardens service readiness/progress reportingOPENCLAW_*env instead of a direct slimclaw runtime dependency, which removes duplicated sidecar payloads in Windows packagingAffected areas
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpassespnpm generate-typesrun (if API routes/schemas changed)anytypes introduced (useunknownwith narrowing)Notes for reviewers
@nexu/slimclaw.