Fix issues with rsync stage-out mode #6587
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
christopher-hakkaart
approved these changes
Nov 19, 2025
Collaborator
christopher-hakkaart
left a comment
christopher-hakkaart
left a comment
There was a problem hiding this comment.
Docs look good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6214 #6447
This PR fixes the
nxf_fs_rsync()function in the.command.runtemplateThe problem was that
rsyncdoes not actually initialize the target directory prior to copying, whereas I think we assumed that it did. This led to multiple issues:sometimes rsync will copy the source file "as" the target rather than "into" the target (Using
storeDirwithprocess.stageOutMode = "rsync"creates an invalid cache dir #6214)rsync will fail if the target parent directory doesn't already exist (can't create parent directories when stageOutMode is rsync #6447)