Skip to content

Replace drop/list/view commands with pipelines command#5966

Closed
bentsherman wants to merge 5 commits intomasterfrom
5959-cmd-pipelines
Closed

Replace drop/list/view commands with pipelines command#5966
bentsherman wants to merge 5 commits intomasterfrom
5959-cmd-pipelines

Conversation

@bentsherman
Copy link
Copy Markdown
Member

Close #5959

This PR moves the drop, list, and view commands into a single pipelines command:

  • these commands all pertain to managing the pipeline cache
  • they are very generic names which can be confusing as we add more top-level commands
  • list is too similar to lint, easy to misspell

I was originally going to move clone and pull as well, but I'm not sure if there's a clean way to support CLI options for these subcommands with JCommander. I refactored the main three commands to not have any extra options, but I don't think I can do this for clone and pull. Also, moving the pull command might be more disruptive anyway.

Long-term, I think we could introduce a CLI v2 called nf with (1) GNU-style options, (2) picocli over JCommander, and (3) a refactored command tree. So for now I'm happy to just merge this change as a short-term improvement.

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman requested a review from pditommaso April 14, 2025 01:58
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 4b4bd14
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67fc8089f655ab0008911fff
😎 Deploy Preview https://deploy-preview-5966--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bentsherman
Copy link
Copy Markdown
Member Author

One consideration might be to align the pipelines view command with cid show (i.e. lineage show). Would be nice to use the same word for both

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman requested a review from a team as a code owner April 14, 2025 03:06
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman added this to the 25.04 milestone May 1, 2025
@pditommaso
Copy link
Copy Markdown
Member

Let's postpone this, post 25.04. There's no hurry

@pditommaso pditommaso removed this from the 25.04 milestone May 1, 2025
@bentsherman
Copy link
Copy Markdown
Member Author

At that point we might as well not do it, we'll likely have CLI v2 by then

@bentsherman
Copy link
Copy Markdown
Member Author

Yeah, let's just do this in CLI v2

@bentsherman bentsherman closed this May 2, 2025
@bentsherman bentsherman deleted the 5959-cmd-pipelines branch May 2, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Move CLI commands for project management to subcommands

2 participants