Open
Conversation
Do that in one query instead of ending up doing N+1 queries. Signed-off-by: Carl Schwan <carlschwan@kde.org>
nickvergessen
previously requested changes
Apr 9, 2026
Member
There was a problem hiding this comment.
This breaks daily and other master/main instances that run pgsql at least.
https://github.com/nextcloud/text/pull/8421/changes#r3055845268
CarlSchwan
force-pushed
the
backport/8421/stable32
branch
from
ead35bd to
24f20a6
Compare
Decrease time to execute the query from 10s of seconds to a few miliseconds. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
backport/8421/stable32
branch
from
24f20a6 to
b7e5793
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8421
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.