fix(previewOptions): only render link preview options if editor is editable#8404
Merged
silverkszlo merged 1 commit intostable31from Mar 23, 2026
Merged
Conversation
…itable Signed-off-by: silver <s.szmajduch@posteo.de>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
mejo-
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This previous fix #8257 did not resolve the bug entirely as sometimes it appeared and sometimes not. Now
editor.options.editableis being checked inprops.decorationson every view render, including aftersedEditable(), regardless of whether a transaction was dispatched.To reproduce:
view onlypermissions🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)