Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): remove notification on dnd #1152

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(config): remove notification on dnd #1152

wants to merge 2 commits into from
+56 −34

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 4, 2025

☑️ Resolves

  • This option is not available in general case
  • Removed for consistency across clients

🖼️ Screenshots

🏚️ Before 🏡 After
image image

ShGKme added 2 commits March 3, 2025 15:26
@ShGKme
chore: fix TS errors
35460ce 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme
fix(config): remove notification on dnd
4ab2925 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme added bug Something isn't working 3. to review labels Mar 4, 2025
@ShGKme ShGKme added this to the 🪴 Next Release milestone Mar 4, 2025
@ShGKme ShGKme self-assigned this Mar 4, 2025
nickvergessen
nickvergessen approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could keep the non-bool values for the future, but fine either way

@Antreesy
Copy link
Contributor

Antreesy commented Mar 5, 2025

I'd also only drop 'always' for now

@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 5, 2025

Boolean values reflect corresponding config values on the server
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
🪴 Next Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @Antreesy @nickvergessen