Skip to content

fix(files_reminder): passed reminder handling#59228

Open
skjnldsv wants to merge 2 commits intomasterfrom
fix/reminder-past
Open

fix(files_reminder): passed reminder handling#59228
skjnldsv wants to merge 2 commits intomasterfrom
fix/reminder-past

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 26, 2026

Summary

This PR solved two logic issues

  1. we still return passed reminder from the API. We should just assume passed ones are void and basically gone
  2. we assumed a 404 on reminder clear request was an issue, but that's just expected outcome. We can safely disregard this.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@skjnldsv skjnldsv added this to the Nextcloud 34 milestone Mar 26, 2026
@skjnldsv skjnldsv self-assigned this Mar 26, 2026
@skjnldsv skjnldsv requested review from a team as code owners March 26, 2026 13:03
@skjnldsv skjnldsv requested review from nfebe, sorbaugh and szaimen and removed request for a team March 26, 2026 13:03
@skjnldsv skjnldsv requested review from CarlSchwan and leftybournes and removed request for a team March 26, 2026 13:03
@skjnldsv
Copy link
Member Author

/backport to stable33

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv force-pushed the fix/reminder-past branch from bb962d6 to cc7c56c Compare March 26, 2026 13:24
@skjnldsv
Copy link
Member Author

/compile rebase

skjnldsv and others added 2 commits March 26, 2026 14:54
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Once a reminder for a file has passed, it does not disappear and cannot be deleted

3 participants