feat(files_external/s3): make some auth labels clearer#59204
Open
joshtrichards wants to merge 2 commits intomasterfrom
Open
feat(files_external/s3): make some auth labels clearer#59204joshtrichards wants to merge 2 commits intomasterfrom
joshtrichards wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Avoid the use of "authentication" here since this is really about signing compatibility, not the source of credentials. Also prefix with "Use" for UI consistency. Signed-off-by: Josh <josh.t.richards@gmail.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Improve the S3 external storage UI by making two labels more explicit:
Why
The current S3 wording is confusing in two ways:
"Access key" is too vague
It does not clearly communicate that this option expects long-lived static credentials, and it is easily confused with the field label itself.
"Legacy (v2) authentication" is ambiguous
This setting is really about legacy S3 request signing compatibility, not the general authentication method.
These changes make the S3 configuration UI more self-explanatory without changing behavior.
Future follow-up
There is a related UX issue where "None" is misleading for S3. I was also hoping to change that (to something like "Instance metadata"). However, that is being left for a follow-up PR because it has additional design/compatibility hurdles:
SCHEME_NULLis generic acrossfiles_externalnull::nullrather than creating an S3 specific oneBackend::addAuthScheme()works at the scheme level, not per-backend label overrideFor now that one will have to remain labeled "None" as-is in the UI unfortunately...
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)