fix: treat all WebKit iOS browseres the same#59168
fix: treat all WebKit iOS browseres the same#59168philiprenich wants to merge 2 commits intonextcloud:masterfrom
Conversation
Signed-off-by: Philip Renich <hello@philiprenich.com>
philiprenich
requested review from
ArtificialOwl,
CarlSchwan,
come-nc and
icewind1991
and removed request for
a team
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
Summary
This changes the user agent regex used to detect browsers on iOS. Since all browsers there currently use WebKit and render as Mobile Safari, they should be treated the same. The regex does not match the potential upcoming EU-only Gecko-based mobile Firefox. Here is a sample of matching and unmatching UA strings
I also simplified the regex after researching various iPhone/iPad UA strings across the years and models.
Tested In
iOS...
Checklist
3. to review, feature component)stable32)AI (if applicable)