fix: treat mobile Firefox on iOS as mobile Safari#58820
fix: treat mobile Firefox on iOS as mobile Safari#58820ionodeionode wants to merge 1 commit intonextcloud:masterfrom
Conversation
Firefox on iOS uses WebKit engine and should be treated similarly to Safari on iOS for compatibility purposes. Fixes: nextcloud#58656 Signed-off-by: ionodeionode <ionodeionode@users.noreply.github.com>
ebf017e to
80c00a2
Compare
CarlSchwan
left a comment
There was a problem hiding this comment.
Make sense to me but I don't use iOS so i can't test
|
Hi, originally reporter of the issue here. This solution only solves the problem for Firefox. As you'll see in the issue, there was discussion around solving it for all mobile webkit browsers. The PR I've submitted does this in a more generic way, rather than appending browser specific UA strings. (I know this PR could be updated, but I wanted to get a local dev environment working to ensure I could test it all so put my own up) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Firefox on iOS uses the WebKit rendering engine (same as Safari), so it should be treated similarly to mobile Safari for compatibility and feature detection purposes.
Changes
Fixes #58656