fix(ICalendar): allow to search for event URI#59142
Merged
Conversation
mejo-
requested review from
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
mejo-
added
bug
3. to review
Member
|
Also document the option in |
mejo-
force-pushed
the
fix/caldav_search_for_uri
branch
from
52bbc00 to
6b7e212
Compare
mejo-
changed the title
Member
Author
Thanks, done now |
tcitworld
approved these changes
Mar 23, 2026
Member
tcitworld
left a comment
tcitworld
left a comment
There was a problem hiding this comment.
An addition to CalDavBackendTest would be welcomed as well
mejo-
force-pushed
the
fix/caldav_search_for_uri
branch
2 times, most recently
from
f81fbd9 to
08b1e01
Compare
Member
Author
Agreed, also done now |
mejo-
force-pushed
the
fix/caldav_search_for_uri
branch
from
08b1e01 to
7290207
Compare
Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/caldav_search_for_uri
branch
from
7290207 to
f34513d
Compare
hamza221
approved these changes
Mar 23, 2026
Member
Author
|
@tcitworld @hamza221 what do you think about backporting this fix to stable33 at least? Strictly speaking it's an API change, but then it's only an addition and as @tcitworld mentioned in #8048, there's no other implementation using |
Member
|
I'm obviously not the backport manager, but this seems small enough to be safe. |
Member
Author
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for nextcloud/calendar#8048
Checklist
3. to review, feature component)stable32)