refactor(setup): Centralize database password generation in AbstractDatabase#59092
Open
joshtrichards wants to merge 3 commits intomasterfrom
Open
refactor(setup): Centralize database password generation in AbstractDatabase#59092joshtrichards wants to merge 3 commits intomasterfrom
joshtrichards wants to merge 3 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
feature: install and update
technical debt
♻️ refactor
joshtrichards
requested review from
ArtificialOwl,
CarlSchwan,
icewind1991,
nickvergessen and
salmart-dev
and removed request for
a team
nickvergessen
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
MySQL and PostgreSQL used different password generation strategies during setup. MySQL generated 30-char passwords with guaranteed character class diversity (upper, lower, digits, symbols) while PostgreSQL used only 30 alphanumeric characters via a service locator call.
This moves the stronger MySQL implementation into
AbstractDatabaseasgenerateDbPassword()and uses it from both backends. More DRY + this also eliminates an unnecessaryServer::get()call in PostgreSQL setup.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)