Skip to content

feat(files-versions): no versions on presence of .noversion #59091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArtificialOwl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(files-versions): no versions on presence of .noversion #59091

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions apps/files_versions/lib/Storage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ public static function store($filename) {
return false;
}

if (self::ignoredByHiddenFile($file)) {
return false;
}

$mount = $file->getMountPoint();
if ($mount instanceof SharedMount) {
$ownerFolder = $rootFolder->getUserFolder($mount->getShare()->getShareOwner());
Expand Down Expand Up @@ -1007,4 +1011,34 @@ protected static function getExpiration() {
}
return self::$application->getContainer()->get(Expiration::class);
}

/**
* returns TRUE if a file named '.noversion' is found
* in the current folder or in a parent folder
*/
private static function ignoredByHiddenFile(Node $node): bool {
if (!$node instanceof Folder) {
try {
$node = $node->getParent();
} catch (NotFoundException $e) {
\OCP\Server::get(LoggerInterface::class)->warning('parent folder must exist', ['exception' => $e]);
return false;
}
}

$i = 0;
while ($i++ < 30) {
if ($node->nodeExists('.noversion')) {
return true;
}

try {
$node = $node->getParent();
} catch (NotFoundException) {
break;
}
}

return false;
}
}
Loading