feat(updater): add a config toggle to disable adding the BackgroundCleanupUpdaterBackupsJob#59048
Open
feat(updater): add a config toggle to disable adding the BackgroundCleanupUpdaterBackupsJob#59048
Conversation
tcitworld
requested review from
leftybournes and
salmart-dev
and removed request for
a team
tcitworld
force-pushed
the
add-toggle-to-disable-cleanup-updater-backups-jobs
branch
from
fb9c6d6 to
86b5b9f
Compare
…eanupUpdaterBackupsJob Since the updater can be used with --no-backup, which doesn't create the backups folder in the first place, it isn't required to make this check, which sends a warning-level log if it doesn't find the folder. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
add-toggle-to-disable-cleanup-updater-backups-jobs
branch
from
86b5b9f to
9f5da4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the updater can be used with
--no-backup, which doesn't create the backups folder in the first place, it isn't required to make this check in this case, which sends a warning-level log if it doesn't find the folder. So let's add a way to at least skip this.Follow-up to #48674
Checklist
3. to review, feature component)stable32)AI (if applicable)