Skip to content

[stable31] fix(LDAP): use displayname from DB, before reaching out to LDAP#59040

Merged
blizzz merged 3 commits intostable31from
backport/59034/stable31
Mar 18, 2026
Merged

[stable31] fix(LDAP): use displayname from DB, before reaching out to LDAP#59040
blizzz merged 3 commits intostable31from
backport/59034/stable31

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Mar 18, 2026

Backport of #59034

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested a review from blizzz March 18, 2026 14:08
@backportbot backportbot bot self-assigned this Mar 18, 2026
@blizzz blizzz force-pushed the backport/59034/stable31 branch from 3553977 to 43af18b Compare March 18, 2026 14:14
@blizzz blizzz changed the title [stable31] [stable32] fix(LDAP): use displayname from DB, before reaching out to LDAP [stable31] fix(LDAP): use displayname from DB, before reaching out to LDAP Mar 18, 2026
@blizzz blizzz marked this pull request as ready for review March 18, 2026 14:14
@blizzz blizzz requested review from a team, CarlSchwan, come-nc, icewind1991, miaulalala and provokateurin and removed request for a team March 18, 2026 14:15
blizzz added 3 commits March 18, 2026 15:25
As we do it with other information of the user, we now use the known value
of a users displayname, and leave the updating to the background job. This
improves performance of user facing actions where the display name is
required and reduces queries to the LDAP server that are typically more
expensive.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the backport/59034/stable31 branch from 43af18b to a7159c2 Compare March 18, 2026 14:26
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 18, 2026
@blizzz blizzz merged commit b0210d0 into stable31 Mar 18, 2026
206 of 213 checks passed
@blizzz blizzz deleted the backport/59034/stable31 branch March 18, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: ldap performance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants