fix(files_external): properly handle API errors#59033
Merged
Conversation
Contributor
Author
|
/backport to stable33 |
AndyScherzinger
approved these changes
Mar 18, 2026
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-external-issues
branch
from
d85c80a to
a24fc77
Compare
Contributor
Author
|
stable32 handled here: #59037 |
2 tasks
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update password confirmation to allow us to handle API errors.
Otherwise they also were handled just like confirmation issues.
In case of API error we want to reopen the "add storage" dialog which needed some adjustments as some boolean options are send back from the server as strings instead of proper boolean.
Checklist
3. to review, feature component)stable32)AI (if applicable)