Skip to content

fix(apporder): Load custom app order before resolving closures#58959

Merged
nickvergessen merged 1 commit intomasterfrom
bugfix/spreed-16678/load-custom-app-order-earlier
Mar 16, 2026
Merged

fix(apporder): Load custom app order before resolving closures#58959
nickvergessen merged 1 commit intomasterfrom
bugfix/spreed-16678/load-custom-app-order-earlier

Conversation

@nickvergessen
Copy link
Member

Summary

Ref: nextcloud/spreed#16678 (comment)

It required an app that registers a page alphabetically after Talk (spreed) via the add method (closure or not does not matter).
The problem is this resolves the closure of Talk, but does not load the custom app order before, so Talk is still -5.

Steps

  1. Enable Talk
  2. Enable thesearchpage app, external app, or something similar
  3. Change app order and move Talk lower
  4. Talk is still first

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 34 milestone Mar 15, 2026
@nickvergessen nickvergessen self-assigned this Mar 15, 2026
@nickvergessen nickvergessen requested a review from a team as a code owner March 15, 2026 14:35
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Mar 15, 2026
@nickvergessen nickvergessen requested review from ArtificialOwl, artonge, icewind1991 and salmart-dev and removed request for a team March 15, 2026 14:35
@nickvergessen nickvergessen merged commit b17d518 into master Mar 16, 2026
190 of 196 checks passed
@nickvergessen nickvergessen deleted the bugfix/spreed-16678/load-custom-app-order-earlier branch March 16, 2026 10:37
@nickvergessen
Copy link
Member Author

/backport to stable33

@nickvergessen
Copy link
Member Author

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hardcoded app order value overwrites user-set app order

3 participants