Skip to content

[stable33] Stable33 authoritative share#58894

Merged
sorbaugh merged 31 commits intostable33from
stable33-authoritative-share
Mar 20, 2026
Merged

[stable33] Stable33 authoritative share#58894
sorbaugh merged 31 commits intostable33from
stable33-authoritative-share

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Mar 12, 2026

@icewind1991 icewind1991 added the 2. developing Work in progress label Mar 12, 2026
@github-actions github-actions bot changed the title Stable33 authoritative share [stable33] Stable33 authoritative share Mar 12, 2026
@icewind1991 icewind1991 force-pushed the stable33-authoritative-share branch 5 times, most recently from d364ee7 to 9e2bc29 Compare March 16, 2026 22:41
@sorbaugh sorbaugh marked this pull request as ready for review March 19, 2026 12:10
@sorbaugh sorbaugh requested a review from a team as a code owner March 19, 2026 12:10
@sorbaugh sorbaugh requested review from Altahrim, CarlSchwan, leftybournes and nfebe and removed request for a team March 19, 2026 12:10
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Mar 19, 2026
@nickvergessen
test(server): Run tests again nextcloud/server#58894 stable33-authori…
61961f1 
…tative-share

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Mar 19, 2026
Open
2 tasks
@icewind1991 @artonge
fix: only refresh mounts once per user
fb49d9c 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: also use authoritative mount info for setupForProvider
824c142 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@artonge artonge force-pushed the stable33-authoritative-share branch from 9e2bc29 to 0650444 Compare March 19, 2026 17:34
@icewind1991 @artonge
feat: perform share mount validation on share instead of on mount
ffa6784 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
perf: only update shares for users once
7e16d3f 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: adjust SharesUpdatedListener to event change
ecbc0d8 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
feat: add event for tranfered shares
b4bc48b 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: remove validate-user-shares-once optimization
7c7d0bd 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: prevent recursion in SharesUpdatedListener
563ff9f 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
feat: implement authoritative mount provider for share provider
d718d68 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: only validate mounts for new share
aa9697c 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
feat: add event for user home mount having being setup
92274d9 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
chore: move share recipient validation logic to a separate class
e306017 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
feat: postpone receiving share validation after processing a certain …
08bec7e 
…number of users

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
test: add test for delayed share validate
2b8f96b 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: disable share resolve postpone in tests
7c53aff 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
feat: export getData for public FileInfo interface
42c6ffa 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: clear in-memory cached mounts for user when adding/removing mounts
4182552 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
test: add reusable mock implementation for IAppConfig
ca87da8 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
test: add reusable mock implementation for IUserConfig
7b3702b 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
test: add some tests for SharesUpdatedListenerTest
b86f145 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
test: add some tests for ShareRecipientUpdaterTest
320d0d0 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
feat: use time-based cutoff for share updating instead of count
3a804a4 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: improve performance of handling delete shares
92515d1 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
feat: add output options and '--cached-only' to list mounts command
ce90ec0 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: update shares on group delete
e63fe87 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
test: add more integration tests for share mount handling
03a18bd 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: handle share moves
fad6a86 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
test: adjust tests
15cef14 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: don't error when moving a non-existing mount
6464ecf 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: fix moving mountpoints
64151e9 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @artonge
fix: move mountpoint when transfering share
9b9b7e2 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@artonge artonge force-pushed the stable33-authoritative-share branch from 0650444 to 9b9b7e2 Compare March 19, 2026 17:39
@sorbaugh sorbaugh merged commit af8d78a into stable33 Mar 20, 2026
232 of 238 checks passed
@sorbaugh sorbaugh deleted the stable33-authoritative-share branch March 20, 2026 09:15
@nextcloud-bot nextcloud-bot mentioned this pull request Mar 20, 2026
Open
@artonge artonge mentioned this pull request Mar 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan CarlSchwan is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

2. developing Work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991 @artonge @sorbaugh