Skip to content

feat(theming): add --color-mark CSS variable for highlighted text#58830

Merged
mejo- merged 1 commit intomasterfrom
feat/color_mark_css_variable
Mar 17, 2026
Merged

feat(theming): add --color-mark CSS variable for highlighted text#58830
mejo- merged 1 commit intomasterfrom
feat/color_mark_css_variable

Conversation

@mejo-
Copy link
Copy Markdown
Member

@mejo- mejo- commented Mar 10, 2026

Required for nextcloud/text#8309

Screenshots

Bright mode Dark mode
image image

Checklist

@mejo- mejo- added this to the Nextcloud 34 milestone Mar 10, 2026
@mejo- mejo- requested a review from marcoambrosini March 10, 2026 12:10
@mejo- mejo- self-assigned this Mar 10, 2026
@mejo- mejo- requested review from a team as code owners March 10, 2026 12:10
@mejo- mejo- added 3. to review Waiting for reviews feature: theming labels Mar 10, 2026
@mejo- mejo- requested review from Altahrim, icewind1991, nfebe, salmart-dev, skjnldsv, susnux and szaimen and removed request for a team March 10, 2026 12:10
mejo- added a commit to nextcloud/text that referenced this pull request Mar 10, 2026
Uses Tiptap Highlight extension and markdown-it mark plugin.

Requires nextcloud/server#58830

Fixes: #1575

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- requested a review from ShGKme March 10, 2026 13:06
@mejo- mejo- added the design Design, UI, UX, etc. label Mar 10, 2026
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contrast ratio:

  • ✅ Light: 14.04:1
  • ✅ Dark: 9.36:1

We can also add the style for the <mark> element.

@mejo-
Copy link
Copy Markdown
Member Author

mejo- commented Mar 11, 2026

We can also add the style for the element.

Sure, I can add this. What would be the appropriate place? core/css/styles.scss? Or core/css/apps.scss?

@ShGKme
Copy link
Copy Markdown
Contributor

ShGKme commented Mar 11, 2026

core/css/styles.scss?

Yes

@mejo- mejo- force-pushed the feat/color_mark_css_variable branch from f835319 to 79af025 Compare March 17, 2026 16:55
Required for nextcloud/text#8309

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/color_mark_css_variable branch from 79af025 to 39a0545 Compare March 17, 2026 17:04
@mejo- mejo- merged commit b960838 into master Mar 17, 2026
235 of 247 checks passed
@mejo- mejo- deleted the feat/color_mark_css_variable branch March 17, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: theming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants