refactor(password-confirmation): better condition#58721
Open
ArtificialOwl wants to merge 1 commit intomasterfrom
Open
refactor(password-confirmation): better condition#58721ArtificialOwl wants to merge 1 commit intomasterfrom
ArtificialOwl wants to merge 1 commit intomasterfrom
Conversation
ArtificialOwl
requested review from
artonge,
come-nc,
icewind1991 and
sorbaugh
and removed request for
a team
artonge
approved these changes
Mar 4, 2026
lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
refactor/password-confirmation/better-condition
branch
from
17ad248 to
d250c4a
Compare
artonge
added
enhancement
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small and smooth refactoring