feat(taskprocessing): Add queue_stats API endpoint for external autoscalers#58376
Open
oleksandr-nc wants to merge 1 commit intomasterfrom
Open
feat(taskprocessing): Add queue_stats API endpoint for external autoscalers#58376oleksandr-nc wants to merge 1 commit intomasterfrom
oleksandr-nc wants to merge 1 commit intomasterfrom
Conversation
marcelklehr
reviewed
Feb 23, 2026
| try { | ||
| $taskTypeIds = []; | ||
| if ($taskTypeId !== null) { | ||
| $taskTypeIds = array_map('trim', explode(',', $taskTypeId)); |
Member
There was a problem hiding this comment.
can't we simply demand an array here instead of a comma-separated list?
marcelklehr
approved these changes
Feb 23, 2026
oleksandr-nc
force-pushed
the
feat/taskprocessing/keda-autoscaler
branch
from
eed2cdd to
e099331
Compare
marcelklehr
reviewed
Feb 23, 2026
| #[NoCSRFRequired] | ||
| #[ApiRoute(verb: 'GET', url: '/queue_stats', root: '/taskprocessing')] | ||
| public function queueStats(array $taskTypeIds = []): DataResponse { | ||
| # TODO: bruteforce protection? |
Member
There was a problem hiding this comment.
mh, shouldn't be necessary I think 🤔 It's an admin only endpoint and it doesn't do much
Member
|
Not sure how useful unit tests are in this case 🤔 We can keep them, but if we want proper test coverage, I'd argue we should test against a real db as well. |
oleksandr-nc
force-pushed
the
feat/taskprocessing/keda-autoscaler
branch
from
e099331 to
08e97d5
Compare
…calers Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
force-pushed
the
feat/taskprocessing/keda-autoscaler
branch
from
08e97d5 to
6d42d50
Compare
oleksandr-nc
requested review from
Altahrim,
ArtificialOwl and
icewind1991
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a new admin-only OCS endpoint (GET /taskprocessing/queue_stats) that returns the count of scheduled and running tasks, designed for KEDA and similar external scalers to poll for queue depth.
TODO
Checklist
3. to review, feature component)stable32)