fix(sharing): Prevent empty password when checkbox is enabled#58226
Merged
fix(sharing): Prevent empty password when checkbox is enabled#58226
Conversation
nfebe
requested review from
Altahrim,
ArtificialOwl,
leftybournes,
sorbaugh,
susnux and
szaimen
and removed request for
a team
susnux
reviewed
Feb 10, 2026
nfebe
force-pushed
the
fix/password-state-management
branch
from
4bf7be8 to
d31b7eb
Compare
susnux
approved these changes
Mar 19, 2026
Set passwordProtectedState explicitly when initializing shares with default passwords. This ensures the checkbox state is tracked independently of the password value, preventing it from unchecking when the password field is cleared. Also block saving new shares when password protection is enabled but no password is entered, regardless of enforcement settings. Added passWithNoTests to vitest configs to handle Vue 2/3 dual frontend test runs gracefully. Fixes: #57732, #57011 Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/password-state-management
branch
from
36d23db to
e7f8950
Compare
Contributor
Author
|
/compile / |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/58226/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0cb96fb7 e7f8950d c5e9a159
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58226/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set passwordProtectedState explicitly when initializing shares with default passwords. This ensures the checkbox state is tracked independently of the password value, preventing it from unchecking when the password field is cleared.
Also block saving new shares when password protection is enabled but no password is entered, regardless of enforcement settings.
Added passWithNoTests to vitest configs to handle Vue 2/3 dual frontend test runs gracefully.