Skip to content

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Oct 22, 2025

Summary

Allows to set configuration based on hostname.
With this PR, we can have a unique server ID for Snowflake IDs, easily linked to the right server.

Variable priority

serverid (and other host defined variables) will be taken from:

  • environment
  • hostname configuration ($CONFIG_HOSTNAME)
  • general configuration ($CONFIG)

TODO

  • Allows to configure serverid with environment variable

Checklist

@Altahrim Altahrim added this to the Nextcloud 33 milestone Oct 22, 2025
@Altahrim Altahrim self-assigned this Oct 22, 2025
@Altahrim Altahrim requested a review from a team as a code owner October 22, 2025 09:06
@Altahrim Altahrim removed the request for review from a team October 22, 2025 09:06
@Altahrim Altahrim added the 3. to review Waiting for reviews label Oct 22, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team Oct 22, 2025
@Altahrim Altahrim force-pushed the feat/server_dependant_config branch 2 times, most recently from 8b1db2e to 1bf4677 Compare October 22, 2025 11:42
@Altahrim Altahrim force-pushed the feat/snowflakeIds branch 2 times, most recently from d187a2e to a62c8b2 Compare October 23, 2025 08:33
@Altahrim Altahrim force-pushed the feat/server_dependant_config branch from 1bf4677 to a03b66f Compare October 23, 2025 08:41
@Altahrim Altahrim force-pushed the feat/snowflakeIds branch 2 times, most recently from 1c78c60 to 6766d0a Compare October 23, 2025 09:05
@Altahrim Altahrim force-pushed the feat/server_dependant_config branch from a03b66f to 33dd6b2 Compare October 23, 2025 09:06
@Altahrim Altahrim added pending documentation This pull request needs an associated documentation update 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 23, 2025
Base automatically changed from feat/snowflakeIds to master October 29, 2025 08:11
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, mostly comments about the snowflake part 🐵

@Altahrim Altahrim marked this pull request as draft October 29, 2025 16:24
@Altahrim Altahrim force-pushed the feat/server_dependant_config branch from 33dd6b2 to 36ce481 Compare October 29, 2025 16:24
@Altahrim
Copy link
Collaborator Author

Adding variables specific to server in the configuration seems risky for now.
If config.php is written from Nextcloud it may change the value for all hosts (because of the merge).
I'll open a new PR with only serverid and it's use with snowflake IDs

@Altahrim Altahrim closed this Oct 30, 2025
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress pending documentation This pull request needs an associated documentation update

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

3 participants