-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(config): allow to override some config values by hostname #55904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8b1db2e to
1bf4677
Compare
d187a2e to
a62c8b2
Compare
1bf4677 to
a03b66f
Compare
1c78c60 to
6766d0a
Compare
a03b66f to
33dd6b2
Compare
6766d0a to
4b1fce7
Compare
ae7d14e to
336cc3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, mostly comments about the snowflake part 🐵
Signed-off-by: Benjamin Gaussorgues <[email protected]>
33dd6b2 to
36ce481
Compare
|
Adding variables specific to server in the configuration seems risky for now. |
Summary
Allows to set configuration based on hostname.
With this PR, we can have a unique server ID for Snowflake IDs, easily linked to the right server.
Variable priority
serverid(and other host defined variables) will be taken from:$CONFIG_HOSTNAME)$CONFIG)TODO
serveridwith environment variableChecklist
3. to review, feature component)stable32)