Merged
Conversation
mejo-
approved these changes
Mar 26, 2026
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Tested and works well. Thanks a lot for tackling this ❤️
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
elzody
force-pushed
the
fix/hide-widget-sidebar
branch
from
2a4ba05 to
6f56c70
Compare
Collaborator
Author
|
/backport to stable33 please |
Collaborator
Author
|
/backport to stable32 please |
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When going into edit mode inside of an office widget, the sidebar should be closed to increase the viewing area and keep the UI free of clutter. In this PR this is achieved by sending a post message when the edit mode is enabled and the file is embedded in a widget. It might also be worth it to collapse the notebook bar in some cases.
I wanted to accomplish this in a cleaner way, like setting a UI default, but it seems those are overridden by the user's settings and the state is remembered. The post message solution is what I was left with.
Checklist