templateManager: allow using regular document files as templates#5512
Open
meven wants to merge 1 commit intonextcloud:mainfrom
Open
templateManager: allow using regular document files as templates#5512meven wants to merge 1 commit intonextcloud:mainfrom
meven wants to merge 1 commit intonextcloud:mainfrom
Conversation
elzody
approved these changes
Mar 24, 2026
Collaborator
elzody
left a comment
elzody
left a comment
There was a problem hiding this comment.
Even though the issue you mentioned was already resolved with #5475, I think this change still makes sense. Don't forget to --signoff your commits so that the DCO passes.
git commit --amend --signoff --no-editIt seems like the static analysis error is unrelated to this change.
As Collabora Online does not support creating templates, allow the user to reuse documents created with richdocuments as templates. Collabora Online supports thoe as templates. Fixes: nextcloud#5277 Signed-off-by: Méven Car <meven.car@collabora.com>
meven
force-pushed
the
private/meven/template-odt
branch
from
fd81e49 to
b2746f2
Compare
Author
I somehow missed that, we have two codes paths to define which extensions are acceptable as templates now, It would be best to unify them I think rather than making them match. |
juliusknorr
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Collabora Online does not support creating templates, allow the user to reuse documents created with richdocuments as templates.
Collabora Online supports thoe as templates.
Fixes: #5277