1379 widget credentials #1400
Open
1379 widget credentials #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @nwatson3 thank you very much for your PR 🚀! Please give me some time to review and test the changes 🙂 |
|
Sorry for the delay, i did not forget you, just quite busy at the moment 😕 |
AndyScherzinger
force-pushed
the
1379-widget-credentials
branch
from
41e1dc4
to
a875eca
Compare
AndyScherzinger
force-pushed
the
1379-widget-credentials
branch
from
a875eca
to
50fccda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #1379
I think the bug is being caused by the note's content in NoteEditFragment being overwritten with an empty content string from the TextView when the note gets saved before it loads the content into the TextView, and this save may be being caused by the credentials check.
Not pulling from the view, but from the note object itself before any content has been loaded seems to fix.
Sorry if this is missing something obvious, it's my first time working on this project.