Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): bump ckeditor family (main) (major) #8642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deps): bump ckeditor family (main) (major) #8642

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 21, 2023 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@ckeditor/ckeditor5-alignment (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-basic-styles (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-block-quote (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-core (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-dev-utils (source) 37.0.1 -> 43.0.1 age adoption passing confidence
@ckeditor/ckeditor5-editor-balloon (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-editor-decoupled (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-essentials (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-font (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-heading (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-image (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-link (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-list (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-mention (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-paragraph (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-remove-format (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-theme-lark (source) 37.1.0 -> 43.3.1 age adoption passing confidence
@ckeditor/ckeditor5-upload (source) 37.1.0 -> 43.3.1 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Release Notes

ckeditor/ckeditor5 (@​ckeditor/ckeditor5-alignment)

v43.3.1

Compare Source

We are happy to announce the release of CKEditor 5 v43.3.1.

Release highlights

We had to revert a change introduced in v43.3.0 related to the icons export in one of our packages. This was due to unforeseen TypeScript issues in some setups.

Bug fixes
Other changes
Released packages

Check out the Versioning policy guide for more information.

Released packages (summary)

Other releases:

v43.3.0

Compare Source

We are happy to announce the release of CKEditor 5 v43.3.0.

Release highlights
Performance improvements

We have improved how the editor handles the document structure by making it more reliable and efficient to access specific elements and verify their positions.

  • Node index and offset caching: The Node and NodeList elements now cache index and offset values, reducing the need for recalculations and significantly boosting overall performance during model operations.
  • Selection range validation: The newly implemented Position#isValid() method is also utilized to better validate selection ranges, ensuring more consistent behavior in various editing scenarios.
  • Performance improvements in numbers: The editor now loads content between 3x and, in some cases, up to 6x faster, depending on the type and size of the content. For instance, where a specific 200-page document previously took almost 25 seconds to load, the time has now been reduced to just 3.5 seconds.

We’re committed to ongoing performance enhancements, so you can expect even faster, smoother experience in future updates.

Export to Word watermark support

A new configuration option has been added to include a watermark when exporting documents to Word, providing additional flexibility in document branding and protection.

Notable bug fixes and improvements
  • Suggestions retention on revision restore: Suggestions are no longer lost in specific cases when restoring revisions with changes from multiple users. The revision tracking process has been improved to ensure that all operations, including markers, are handled and saved correctly during synchronization. This fix resolves issues where markers were previously not retained, ensuring consistent data handling in collaborative editing scenarios.
  • Action dropdown visibility fix: Resolved an issue where the action dropdown remained hidden after permission changes on comments. The dropdown now properly reflects updated permissions, allowing users to interact with the available actions seamlessly.
  • AI command enhancements:
    • Custom AI Commands are now correctly applied to individual dropdowns when only one group of comments is present, instead of the entire group.
    • Empty comment groups no longer render, improving UI clarity.
    • Fixed an issue where nested AI command menus would close unexpectedly when used within a balloon toolbar, preventing unintended behavior during selection.
Features
  • engine: Introduced the getChildAtOffset() method for model.Element and model.DocumentFragment. (commit)
  • engine: Introduced the Position#isValid() method to check whether the position exists in the current model tree. (commit)
  • export-word: Added a configuration setting for adding a watermark to generated documents.
  • revision-history: Introduced the RevisionTracker#getRevisionDocumentData() and RevisionTracker#getRevisionRootsAttributes() methods to the public scope of the editor API. You can use them to retrieve document data saved with the revision.
  • utils: Made FocusTracker extendable with other FocusTracker instances to allow logical focus tracking across separate DOM sub-trees (see #​17277). (commit)
Bug fixes
  • ai: Empty AI Assistant command groups should not render in the UI.
  • ai: The AI Assistant command list should be flat when only one command group is available.
  • comments: Fixed an issue where the action dropdown remained hidden when permissions allowing actions on a comment changed.
  • engine: The content of an inline object should be handled as a flow root so whitespaces should be trimmed as the content of an inline object element is inside a block element. Closes #​17199. (commit)
  • image: Handle existing picture element correctly on sources downcast. (commit)
  • link: No longer crash editor after removing link from image when LinkConfig#addTargetToExternalLinks: true is set. Closes https://github.com/ckeditor/ckeditor5/issues/17252. (commit)
  • list-multi-level: Multi-level lists should display correctly in RTL mode for Decoupled Editor.
  • pagination: Improved pagination of large tables that are followed by block elements.
  • revision-history: Suggestions are no longer lost in some scenarios when restoring revisions in real-time collaboration.
  • ui: The dropdown menu component should not cause editor blur if used in a BalloonToolbar while the user hovers a nested menu. Closes #​17277. (commit)
  • ui: Made the page unscrollable while the modal is visible. Closes #​17093. (commit)
Other changes
  • engine: Node index and offset related values are now cached in model Node and NodeList to improve performance. (commit)
  • link: Exported link and unlink icons from the ckeditor5-link package. Closes #​17304. (commit)
  • ui: Disabled dragging support for modal windows in the Dialog plugin. Closes #​17290. (commit)
  • ui: Disabled positioning restrictions for modal windows caused by config.ui.viewportOffset. Closes #​17290. (commit)
Released packages

Check out the Versioning policy guide for more information.

Released packages (summary)

Releases containing new features:

Other releases:

v43.2.0

Compare Source

We are happy to announce the release of CKEditor 5 v43.2.0.

Release highlights
Notable improvements
  • Operational Transformation Stability: Significant changes have been made to the OT system, enhancing the undo functionality and real-time collaboration, especially in conflict resolution scenarios. These improvements ensure smoother editor operations during complex interactions.
  • Performance Improvements: We have merged several community-driven performance enhancements (thanks @​sunesimonsen), that optimize the editor’s core engine. While no changes to the editor’s logic were made, these updates improve overall efficiency and responsiveness.
More imports available via ckeditor5 and ckeditor5-premium-features indexes

As users transition to new installation methods (v42.0.0+) with ckeditor5 and ckeditor5-premium-features as the main packages, we are continuously addressing missing imports for less common classes, functions, types, and utilities, broadening their availability. Since our TypeScript rewrite (v37.0.0), imports can now be made directly through the package indexes, simplifying integration. As many users historically imported from src, we encourage you to try the new version and report any missing imports. In the future, we are considering removing src from published packages to reduce package size, so the more feedback we receive, the better and more stable API we will provide.

Features
Bug fixes
  • ckbox: Editing inline images using CKBox no longer changes and reinserts them simultaneously. Closes #​17056. (commit)
  • engine: Fixed incorrect marker handling in some scenarios involving undo and real-time collaboration, which earlier led to a model-nodelist-offset-out-of-bounds error. See #​9296. (commit)
  • engine: Fixed incorrect handling of merge changes during undo in some scenarios involving real-time collaboration, which earlier led to a model-nodelist-offset-out-of-bounds error. See #​9296. (commit)
  • engine: Fixed conflict resolution error, which led to editor crash in some scenarios where two users removed larger intersecting part of the content and used undo. See #​9296. (commit)
  • engine: Fixed incorrect undo behavior leading to an editor crash when a user pressed Enter key multiple times, then pressed backspace that many times, then undid all the changes. Closes #​9296. (commit)
  • theme-lark: Increased the specificity of the dropdown menu panel styles to address issues with incorrect z-index ordering. (commit)
  • ui: Fixed scrolling in dropdowns when a block toolbar button is active. Closes #​17067. (commit)
  • ui: Increased the specificity of the dropdown menu panel styles to address issues with incorrect z-index ordering. (commit)
Other changes
Released packages

Check out the Versioning policy guide for more information.

Released packages (summary)

Releases containing new features:

Other releases:

Configuration

📅 Schedule: Branch creation - "before 5am on wednesday" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested review from ChristophWurst and GretaD July 21, 2023 08:12
@ChristophWurst ChristophWurst requested review from kesselb and removed request for ChristophWurst July 21, 2023 08:12
@ChristophWurst
Copy link
Member

@kesselb this one is for you :)

@ChristophWurst
Copy link
Member

ckeditor/ckeditor5#14082

^ @jancborchardt @marcoambrosini @nimishavijay ckeditor will show a ckeditor logo with v38 and later. Would that be a problem for us design-wise?

@nimishavijay
Copy link
Member

Where is this ckeditor used? :) And do we have control over how the logo is shown?

@ChristophWurst
Copy link
Member

ChristophWurst commented Jul 21, 2023 •
edited
Loading

CKEditor is the editor we use for the body of new emails. I don't think we have direct control over where/how the logo shows but we might be able to tweak that with css. Yet that's something we have to check with the license of the editor.

@kesselb
Copy link
Contributor

kesselb commented Jul 21, 2023

And do we have control over how the logo is shown?

They provide a couple of customization options: https://ckeditor.com/docs/ckeditor5/latest/support/licensing/managing-ckeditor-logo.html#how-to-configure-the-layout-of-the-powered-by-ckeditor-logo

@kesselb
Copy link
Contributor

kesselb commented Jul 21, 2023

Signature editor:

Screenshot from 2023-07-21 12-11-03

Composer view:

Screenshot from 2023-07-21 12-12-33

@kesselb
Copy link
Contributor

kesselb commented Jul 21, 2023

As idea:

Hiding the label and changing position is possible.

ui: {
	poweredBy: {
		position: 'inside',
		side: 'right',
		label: null,
		verticalOffset: 2,
		horizontalOffset: 2
	}
}

image

image

@nimishavijay
Copy link
Member

Screenshots by @kesselb look good to me. If possible we could link the image to their website/repo. @jancborchardt is this ok with you?

@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 6d235ba to 3bb986f Compare August 2, 2023 10:51
@renovate renovate bot changed the title fix(deps): bump ckeditor family from 37.1.0 to v38 (main) (major) fix(deps): bump ckeditor family from 37.1.0 to v39 (main) (major) Aug 2, 2023
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 3bb986f to 61fe5ff Compare August 10, 2023 07:46
@jancborchardt
Copy link
Member

jancborchardt commented Aug 10, 2023 •
edited
Loading

Oh wow, that's sort of invasive and nerdy.

  • Is CKEditor not really open source, as in we can't hide the logo? (We can happily have a note of it in the bottom left settings.)
  • Do we have to link the logo? Bottom right is the best placement but I am worried about misclicks when sending.

@kesselb
Copy link
Contributor

kesselb commented Aug 10, 2023 •
edited
Loading

Is CKEditor not really open source, as in we can't hide the logo? (We can happily have a note of it in the bottom left settings.)

Technically, we can hide the logo.

I can't judge whether that's okay or not. The topic is also discussed at ckeditor/ckeditor5#14082 (comment) and ckeditor/ckeditor5#14314.

Do we have to link the logo? Bottom right is the best placement but I am worried about misclicks when sending.

They don't provide an option to not generate a link.

image

I moved the send button to the left. Not much better.

Screencast.from.2023-08-10.22-35-07.webm

That's super annoying. The logo is visible if you focus on the editor.
I am uncertain if that was already the case for 38 or is new in 39.

@marcoambrosini
Copy link
Member

I also think that if it's open source we should hide the logo from the composer and add attribution in the app settings. Once those settings are moved to a settings dialog this could even be a small paragraph.

@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 61fe5ff to 305ca2e Compare September 6, 2023 10:35
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 305ca2e to c064b22 Compare October 4, 2023 13:15
@renovate renovate bot changed the title fix(deps): bump ckeditor family from 37.1.0 to v39 (main) (major) fix(deps): bump ckeditor family from 37.1.0 to v40 (main) (major) Oct 4, 2023
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from c064b22 to eac28f3 Compare October 5, 2023 07:20
@renovate renovate bot changed the title fix(deps): bump ckeditor family from 37.1.0 to v40 (main) (major) fix(deps): bump ckeditor family (main) (major) Oct 5, 2023
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 46df855 to c21ed19 Compare October 19, 2023 08:24
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from a115a27 to ac6eca5 Compare October 30, 2023 09:27
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 4c79050 to 86e2016 Compare July 2, 2024 13:38
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 4 times, most recently from 57f1a63 to f8032bc Compare July 11, 2024 13:36
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 3 times, most recently from 103ccca to 9893f82 Compare July 23, 2024 09:44
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 2a10e35 to 1d4d11b Compare July 29, 2024 10:59
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 737ed98 to 36bfc52 Compare August 13, 2024 08:56
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from d175b1a to ad8c035 Compare September 5, 2024 10:34
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from 8b7ea29 to dc4d1f1 Compare September 13, 2024 23:13
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 3 times, most recently from 34538c0 to 2238300 Compare October 2, 2024 09:09
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 2238300 to 90591d7 Compare October 2, 2024 12:40
@kesselb kesselb self-assigned this Oct 3, 2024
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 90591d7 to fd4e919 Compare October 3, 2024 10:40
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from fd4e919 to 573b041 Compare October 16, 2024 11:45
@ChristophWurst
Copy link
Member

I talked with @jancborchardt about this and CKEditor is GPLv2 and our code is AGPLv3-or-later so the code bases are compatible and we are allowed to modify the editor.
As an alternative for the in-place logo we will credit CKEditor in the README.md of this repo and an "About" section of the app settings modal.

@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch 2 times, most recently from bb913be to 3e22b2e Compare October 29, 2024 12:30
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from 3e22b2e to ef86e59 Compare November 6, 2024 09:31
@renovate
fix(deps): bump ckeditor family
1e7823a 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/main-major-ckeditor-family branch from ef86e59 to 1e7823a Compare November 13, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kesselb kesselb

Labels
3. to review dependencies
Projects
💌 📅 👥 Groupware team
Status: 🧭 Planning evaluation
🖍 Design team
Status: 🏗️ At engineering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristophWurst @nimishavijay @kesselb @jancborchardt @marcoambrosini