-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add notification for quota depletion #8610
Conversation
c2f10a0
to
2073e2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it using your proposed hack and it seems to work.
The notification entries are created in the notifications table but they don't show up in the web ui for some reason. I also attached a debugger to the cron to make sure that the notification is triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
$this->jobList = $jobList; | ||
$this->mailManager = $mailManager; | ||
|
||
$this->setInterval(24 * 60 * 60); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO doing this less often would be fine too. The quota won't grow so rapidly. If it does, we won't catch it in time anyway.
Signed-off-by: Anna Larch <[email protected]>
fcaf0df
to
8041d81
Compare
Fixes #8513
How to test
If your hoster doesn't support the QUOTA extension, you can replace the code in the background job with the following:
Current text:
To Do