fix: accept avatars with image/vnd.microsoft.icon mime types #10343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mime type image/x-icon is not registered with the IANA. Instead, image/vnd.microsoft.icon is the preferred mime type for .ico files. Signed-off-by: Richard Steinmetz <[email protected]>
SebastianKrupinski
approved these changes
Nov 12, 2024
|
/backport to stable4.1 |
|
/backport to stable3.7 |
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avatars sourced from favicons won't render if they are provided as .ico files.
The mime type
image/x-iconis not registered with the IANA. Instead,image/vnd.microsoft.iconis the preferred mime type for .ico files.The unofficial type
image/x-iconis mostly used by Microsoft software (ironically).