Skip to content

fix #959: normalize switch statement case #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karlbeecken wants to merge 1 commit into from
Closed

fix #959: normalize switch statement case #1155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/LDAPGroupManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,17 +116,17 @@ public function addToGroup($uid, $gid) {
$groupDN = $this->ldapProvider->getGroupDN($gid);

$entry = [];
switch ($this->ldapProvider->getLDAPGroupMemberAssoc($gid)) {
case 'memberUid':
switch (strtolower($this->ldapProvider->getLDAPGroupMemberAssoc($gid))) {
case 'memberuid':
$entry['memberuid'] = $uid;
break;
case 'uniqueMember':
case 'uniquemember':
$entry['uniquemember'] = $this->ldapProvider->getUserDN($uid);
break;
case 'member':
$entry['member'] = $this->ldapProvider->getUserDN($uid);
break;
case 'gidNumber':
case 'gidnumber':
throw new Exception('Cannot add to group when gidNumber is used as relation');
break;
}
Expand Down Expand Up @@ -156,17 +156,17 @@ public function removeFromGroup($uid, $gid) {
$groupDN = $this->ldapProvider->getGroupDN($gid);

$entry = [];
switch ($this->ldapProvider->getLDAPGroupMemberAssoc($gid)) {
case 'memberUid':
switch (strtolower($this->ldapProvider->getLDAPGroupMemberAssoc($gid))) {
case 'memberuid':
$entry['memberuid'] = $uid;
break;
case 'uniqueMember':
case 'uniquemember':
$entry['uniquemember'] = $this->ldapProvider->getUserDN($uid);
break;
case 'member':
$entry['member'] = $this->ldapProvider->getUserDN($uid);
break;
case 'gidNumber':
case 'gidnumber':
throw new Exception('Cannot remove from group when gidNumber is used as relation');
}

Expand Down