Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix labeled version autoExpire #3393

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix labeled version autoExpire #3393

merged 1 commit into from
Nov 13, 2024

Conversation

XueSheng-GIT
Copy link
Contributor

Fix #3095

Follow up to #3213 which did not consider labeled versions of getAutoExpireList.

@XueSheng-GIT XueSheng-GIT mentioned this pull request Oct 31, 2024
Closed
@XueSheng-GIT XueSheng-GIT marked this pull request as ready for review November 2, 2024 04:25
@XueSheng-GIT
Copy link
Contributor Author

@artonge do I need to squash the commits or is it fine like that?

@artonge
Copy link
Contributor

artonge commented Nov 5, 2024

@artonge do I need to squash the commits or is it fine like that?

Yes please :)

@artonge artonge added bug 3. to review Items that need to be reviewed php Items related to PHP updates and code issues feature: versions Items related to file versioning labels Nov 5, 2024
@artonge artonge added this to the Nextcloud 31 milestone Nov 5, 2024
@artonge
Copy link
Contributor

artonge commented Nov 5, 2024

/backport to stable30

@artonge
Copy link
Contributor

artonge commented Nov 5, 2024

/backport to stable29

@artonge
Copy link
Contributor

artonge commented Nov 5, 2024

/backport to stable28

@artonge artonge mentioned this pull request Nov 5, 2024
Merged
@XueSheng-GIT @artonge
Fix labeled version expiry
082d6d0 
Co-authored-by: Louis <[email protected]>
Signed-off-by: XueSheng-GIT <[email protected]>
@XueSheng-GIT
Copy link
Contributor Author

@artonge anything else I need to do to get this fix merged?

@artonge artonge merged commit d49859f into nextcloud:master Nov 13, 2024
85 of 87 checks passed
This was referenced Nov 13, 2024
Closed
Merged
@artonge
Copy link
Contributor

artonge commented Nov 13, 2024

@artonge anything else I need to do to get this fix merged?

Nothing, just for me to have the time to review again :)

Thanks for the fix !!

@backportbot backportbot bot mentioned this pull request Nov 13, 2024
Merged
@XueSheng-GIT XueSheng-GIT deleted the fix-labeled-version-expiry branch November 13, 2024 15:22
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed bug feature: versions Items related to file versioning feedback-requested php Items related to PHP updates and code issues
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

data loss: named versions are lost from group folder after a while
2 participants
@XueSheng-GIT @artonge