-
Notifications
You must be signed in to change notification settings - Fork 2.4k
docs(admin): improve nginx config php location block structure and clarity #14172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshtrichards
wants to merge
7
commits into
master
Choose a base branch
from
jtr/improve-nginx-php-block-comments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+108
−37
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
02ce7c1
docs(installation): improve comments in php block of nginx-root config
joshtrichards 14bd964
chore: refine php block in nginx-root.conf.sample (WIP)
joshtrichards 7b01b69
chore: final nginx-root.conf.sample cleanup
joshtrichards e3c86e6
chore: update nginx-root.conf.sample version + add handler comment
joshtrichards 56be6e2
chore: port nginx-root.conf.sample changes to subdir conf sample
joshtrichards cc741e2
feat: add identifier to nginx-subdir.conf.sample
joshtrichards f83e14b
feat: add identifier to nginx-root.conf.sample
joshtrichards File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make clear which variables are set by calling
fastcgi_split_path_info:Can be seen from context and Nginx docs, of course, but as we aim to enhance clarity, this could make it easier to read through and understand.