Skip to content

fix(trash bin): Improve clarity of files retention config #13017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 7, 2025

No description provided.

@artonge artonge force-pushed the artonge/fix/trashbin_retention_d1 branch from 6da12de to dc88165 Compare April 7, 2025 08:49
@artonge artonge requested review from yemkareems and come-nc April 8, 2025 07:54
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the parenthesis or some form of it, to make it clear that deletion may never happen.

Also, quota can be infinite, in which case it will still delete files when storage is full I think?

@artonge
Copy link
Contributor Author

artonge commented Apr 23, 2025

I would keep the parenthesis or some form of it, to make it clear that deletion may never happen.

I think deletion will always happen if the quota is reached.

Also, quota can be infinite, in which case it will still delete files when storage is full I think?

I am not sure, at least I haven't found any bit of logic for that. I think expiration is only based on user quota.

@come-nc
Copy link
Contributor

come-nc commented Apr 24, 2025

I would keep the parenthesis or some form of it, to make it clear that deletion may never happen.

I think deletion will always happen if the quota is reached.

But quota may never be reached. That is what is clearer with the previous parenthesis content.

Also, quota can be infinite, in which case it will still delete files when storage is full I think?

I am not sure, at least I haven't found any bit of logic for that. I think expiration is only based on user quota.

Hum, I don’t know, I know that shown quota is storage space when no quota is set, but I do not know for expiration. It should be fixed if it’s not currently the case though, as there is no reason to not expire or full storage if we do it for full quota?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants