-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add documentation about e2ee #12821
base: master
Are you sure you want to change the base?
Conversation
Hello, some suggestions:
Thank you for this documentation! |
d5c9540
to
7a92483
Compare
@artonge If these are okay I can update the PR.
|
I would invert add and mnemonic, no? |
Ahh, yes that's right. I fixed the titles |
Ping @mgallien @marinofaggiana |
This comment was marked as duplicate.
This comment was marked as duplicate.
ideally also include documentation on how to share an e2ee folder with groups and how to create a file drop link, according to https://nextcloud.com/blog/desktop-3-8-end-to-end-encryption-levels-up-with-sharing-and-file-drop/ this is already possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here!! Really nice to see this progressing. 🎉
I would love to see added:
- Description about the mnemonic, such as what it is (i.e. like a password), that it must be kept secret.
- Description of what happens to the folder of encrypted files if all devices are disconnected from the folder, i.e. all clients are deleted/logged out. I believe the files remain in the folder, but inaccessible unless the mnemonic is known by the user. If the mnemonic is not known in this case, the files are lost forever and can not be recovered! Not even/especially by the administrator.
- Limitations of typical Files operations when E2EE is enabled (sharing, copying, etc)
<details> | ||
<summary>Android</summary> | ||
|
||
.. image:: ../images/e2ee-android-add.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- replace re French Android UI (known already)
<details> | ||
<summary>iOS</summary> | ||
|
||
.. image:: ../images/e2ee-ios-add.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add iOS screenshot (missing? 404..)
<details> | ||
<summary>iOS</summary> | ||
|
||
.. image:: ../images/e2ee-ios-mnemonic.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add iOS screenshot (missing?
404
..)
@alperozturk96 still some missing screenshots:
@marinofaggiana still some missing screenshots:
@alperozturk96 @marinofaggiana @mgallien can all of you also add screenshots for the sharing flow? |
Signed-off-by: Louis Chemineau <[email protected]>
7a92483
to
fcaa99a
Compare
Signed-off-by: alperozturk <[email protected]>
@artonge I added the missing screenshots. What do you mean by sharing flow? |
Sharing an E2EE folder with someone else. But thinking about it, it is probably the exact same as for non E2EE folders. Feel free to ignore if this is the case. |
There is no "Share" option in the three-dot menu when I checked it on the Web. On Android, I also noticed empty tabs. We should add these. Could you check it for iOS @marinofaggiana ? |
@marinofaggiana @mgallien @alperozturk96 can you add screenshots for your respective platform?
Note: the android screenshots are in French, so they need to be replaced.
Fix nextcloud/end_to_end_encryption#936