Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unecessary app logic (fix #1213) #2267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Jul 20, 2024

Fix #1911

@joshtrichards
Copy link
Member

Seems fine if this goes away since it was just a passive partial remedy. But perhaps we should create a follow-up issue?123

This seems like something that needs to be nudged upstream to get addressed in Server itself rather than in the downstream images/packagers.

Footnotes

  1. I'm not sure the root issue (of the upstream app update logic not always being robust enough) is fully addressed. AIO actually does more at this point (after originally doing what this PR removes).

  2. Basically to collect data on upgrade problems that are app related and to, maybe, evaluate what (if any) benefits there might be to taking AIO's approach (at least until any deemed appropriate upstream changes are made).

  3. make update process more stable all-in-one#1420 AIO replaced the code under discussion in this PR with a broader scope improvement to make upgrades more robust in Think about making update process more stable all-in-one#1400 / make update process more stable all-in-one#1420

@joshtrichards joshtrichards added this to the Nextcloud 29.0.4 milestone Jul 20, 2024
@joshtrichards joshtrichards added the feature: upgrading Upgrading an existing deployment to a new image/NC version label Jul 20, 2024
@J0WI J0WI mentioned this pull request Oct 8, 2024
@joshtrichards joshtrichards removed this from the Nextcloud 29.0.4 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: upgrading Upgrading an existing deployment to a new image/NC version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled app list stays empty due to missing diffutils on Alpine
2 participants