Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes global network settings #7951

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Removes global network settings #7951

wants to merge 4 commits into from
+158 −287

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Mar 3, 2025 •
edited
Loading

Implements #7919

Only use user specific network settings.

Before:

Screenshot 2025-03-03 at 16 28 33

After:

Screenshot 2025-03-03 at 16 30 55

TO DO:

  • Remove global network settings from the UI
  • Migrate global network settings to user specific network settings
  • Move user and settings to the left (like in Mac OS, in their System Settings)

camilasan added 4 commits March 3, 2025 13:42
@camilasan
Remove "Network" action.
d763d43 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
All proxy settings are account specific settings.
d11c0d8 
The default is to use QNetworkProxy::NoProxy.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Remove global proxy optionfrom UI.
8b35f2e 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Remove proxy global transfer limit settings.
e2d3899 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan camilasan added this to the 3.17.0 milestone Mar 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-7951.zip

SHA256 checksum: f0747f66eb63a9d140034d2c185a128f22de2dd5bc9fa86c2cdfc1d4039184f7

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
6.2% Coverage on New Code (required ≥ 80%)
E Maintainability Rating on New Code (required ≥ A)
137 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra Awaiting requested review from claucambra claucambra will be requested when the pull request is marked ready for review claucambra is a code owner

@mgallien mgallien Awaiting requested review from mgallien mgallien will be requested when the pull request is marked ready for review mgallien is a code owner

@nilsding nilsding Awaiting requested review from nilsding nilsding will be requested when the pull request is marked ready for review nilsding is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.17.0
Development

Successfully merging this pull request may close these issues.
1 participant
@camilasan