Fix looks of share note text field #7854
Merged
+33
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-3.16 |
Signed-off-by: Jyrki Gadinger <[email protected]>
it's already styled properly as it's part of Qt Quick Controls, **and** it allows for a placeholder text! also changed the logic for displaying the text field a bit ... Fixes #7847 Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/native-share-note
branch
from
04ba154 to
7e819b3
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-7854.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7847 by using the
TextAreaQML control instead of the plainTextEditfor share note field; it's already styled properly as it's part of Qt Quick Controls, and it allows for a proper placeholder text!Also fixed some more icons appearing dark in dark mode.
on the Fluent style the text field is larger as well, indicating that it allows for multi-line text entry: