gui/macOS: Improve/fix illegal File Provider domain handling for macOS VFS #7835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
claucambra
commented
Feb 10, 2025
claucambra
commented
- Avoid accidentally turning File Provider domain locations into bundles (Closes [Bug]: cannot open the nextcloud directory on my mac when using .app domain. #7694)
- Fix conversion of sanitised domain identifiers into account identifiers
nilsding
reviewed
Feb 10, 2025
nilsding
approved these changes
Feb 10, 2025
…s breaking access to file provider domains Signed-off-by: Claudio Cambra <[email protected]>
…tifier is illegal or not Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…main names Signed-off-by: Claudio Cambra <[email protected]>
…er implementation Signed-off-by: Claudio Cambra <[email protected]>
mgallien
force-pushed
the
work/app-domain-vfs-domain
branch
from
9974023 to
c140394
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-7835.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.