Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch "shared with me" information separately #7744

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fetch "shared with me" information separately #7744

merged 1 commit into from
Feb 7, 2025

Conversation

nilsding
Copy link
Member

If the parameter shared_with_me is set to "true" on the shares API call the response will only include that and not return any other sharing information. therefore let's fetch it inside another job (this is also how the web client does it).

Fixes #7734.

@nilsding nilsding added this to the 3.16.0 milestone Jan 10, 2025
@nilsding nilsding self-assigned this Jan 10, 2025
@nilsding nilsding marked this pull request as draft January 10, 2025 13:28
claucambra
claucambra requested changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nitpick

src/gui/sharemanager.cpp Outdated Show resolved Hide resolved
camilasan
camilasan reviewed Jan 13, 2025
View reviewed changes
src/gui/ocssharejob.h Outdated Show resolved Hide resolved
@nilsding nilsding force-pushed the bugfix/shares-status branch from fe6439b to 06d904a Compare January 13, 2025 13:48
@nilsding nilsding marked this pull request as ready for review January 13, 2025 13:49
@nilsding
Copy link
Member Author

took some time to figure out why the tests broke... decided to introduce proper signal/slots for this

@nilsding nilsding mentioned this pull request Jan 13, 2025
Closed
8 tasks
@nilsding nilsding mentioned this pull request Jan 16, 2025
Closed
8 tasks
claucambra
claucambra requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to back to previous comment

src/gui/sharemanager.cpp Outdated Show resolved Hide resolved
@nilsding nilsding force-pushed the bugfix/shares-status branch from 06d904a to b1066a2 Compare January 23, 2025 08:12
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7744-b1066a2b592942b188f15418406a4711517df984-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding nilsding requested a review from claucambra January 23, 2025 09:06
camilasan
camilasan requested changes Feb 3, 2025
View reviewed changes
src/gui/filedetails/sharemodel.cpp Outdated Show resolved Hide resolved
src/gui/filedetails/sharemodel.cpp Outdated Show resolved Hide resolved
src/gui/sharemanager.cpp Outdated Show resolved Hide resolved
src/gui/sharemanager.cpp Outdated Show resolved Hide resolved
@nilsding nilsding force-pushed the bugfix/shares-status branch from b1066a2 to 58cf0bd Compare February 4, 2025 09:57
@nilsding nilsding requested a review from camilasan February 4, 2025 09:57
@nilsding nilsding force-pushed the bugfix/shares-status branch from 58cf0bd to 5f2ea39 Compare February 7, 2025 07:24
@nilsding nilsding enabled auto-merge February 7, 2025 07:45
@nilsding nilsding disabled auto-merge February 7, 2025 08:16
@nilsding
fetch "shared with me" information separately
269378e 
if the parameter `shared_with_me` is set to `"true"` on the shares API
call the response will only include that and not return any other
sharing information.  therefore let's fetch it inside another job (this
is also how the web client does it).

Signed-off-by: Jyrki Gadinger <[email protected]>
@nilsding nilsding force-pushed the bugfix/shares-status branch from 5f2ea39 to 269378e Compare February 7, 2025 08:22
@nilsding nilsding enabled auto-merge February 7, 2025 08:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-7744.zip

SHA256 checksum: 48e2d6bbbba3b6bc45098229cd77b1a2bf6d254765eeb58cf2d0a67d03eedc7b

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
65.5% Coverage on New Code (required ≥ 80%)
C Maintainability Rating on New Code (required ≥ A)
30 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@nilsding nilsding merged commit 08de4ff into master Feb 7, 2025
13 of 16 checks passed
@nilsding nilsding deleted the bugfix/shares-status branch February 7, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan camilasan approved these changes

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees

@nilsding nilsding

Labels
3. to review
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Share status as shown in Desktop Client share dialog is not consistent with a file share status
4 participants
@nilsding @nextcloud-desktop-bot @camilasan @claucambra