Skip to content

Fix: Reduce z-index for some elements to prevent conflicts with embedded calendar popup#2357

Merged
mejo- merged 1 commit intomainfrom
bugfix/reduce-z-index
Apr 15, 2026
Merged

Fix: Reduce z-index for some elements to prevent conflicts with embedded calendar popup#2357
mejo- merged 1 commit intomainfrom
bugfix/reduce-z-index

Conversation

@Koc
Copy link
Copy Markdown
Contributor

@Koc Koc commented Mar 20, 2026 •
edited
Loading

📝 Summary

Reproducer:

  1. install Calendar module
  2. embedd calendar into Collective
  3. create event with huge text
  4. open event in embedded calendar

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@Koc Koc marked this pull request as ready for review March 20, 2026 10:47
@Koc Koc force-pushed the bugfix/reduce-z-index branch from 1327ca4 to 5194f9e Compare March 20, 2026 10:47
@mejo-
Copy link
Copy Markdown
Member

mejo- commented Mar 23, 2026

Thanks @Koc. While testing it I realized that the menubar in edit mode still overlays the calendar popup. And it seems like we set the z-index of 10021 for the menubar so it always is on top of the NcModal header, which has z-index: 10001.

From my manual tests I don't understand when the text menubar should overlay NcModal and wonder whether that's a leftover from the past. @max-nextcloud @juliusknorr do you have an idea?

@max-nextcloud
Copy link
Copy Markdown
Collaborator

max-nextcloud commented Mar 23, 2026

@mejo- I do not remember. 83c1d21 Looks like the z-index it was there right from the start.

@Koc Koc force-pushed the bugfix/reduce-z-index branch from 5194f9e to 89eb58f Compare March 25, 2026 23:54
@Koc
Copy link
Copy Markdown
Contributor Author

Koc commented Mar 25, 2026

@mejo- thanx for finging, fixed

image

mejo-
mejo- requested changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing this I think we should remove the z-index from page-info-bar, .text-menubar and .editor--outline altogether. For .page-title we should adjust it to only be higher than the editor content.

We need a respective PR in Text as well to do the same there. @Koc do you want to take care of this?

mejo- added a commit to nextcloud/text that referenced this pull request Apr 15, 2026
@mejo-
fix(menubar): lower z-index: on top of document content, but below mo…
796ecd4 
…dals

Contributes to nextcloud/collectives#2357

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this pull request Apr 15, 2026
Merged
2 tasks
@Koc @mejo-
Fix: Reduce z-index for some elements below embedded calendar popup
1f20723 
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the bugfix/reduce-z-index branch from 89eb58f to 1f20723 Compare April 15, 2026 09:19
@mejo- mejo- added bug Something isn't working 3. to review labels Apr 15, 2026
mejo-
mejo- approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Koc I adjusted the PR and opened nextcloud/text#8469 in Text to address the problem.

@mejo- mejo- added the papercut label Apr 15, 2026
@mejo- mejo- merged commit da9efc6 into main Apr 15, 2026
56 of 59 checks passed
backportbot bot pushed a commit to nextcloud/text that referenced this pull request Apr 15, 2026
@mejo- @backportbot
fix(menubar): lower z-index: on top of document content, but below mo…
1652459 
…dals

Contributes to nextcloud/collectives#2357

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- deleted the bugfix/reduce-z-index branch April 15, 2026 09:39
backportbot bot pushed a commit to nextcloud/text that referenced this pull request Apr 15, 2026
@mejo- @backportbot
fix(menubar): lower z-index: on top of document content, but below mo…
b8e5e46 
…dals

Contributes to nextcloud/collectives#2357

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejo- mejo- mejo- approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

@silverkszlo silverkszlo Awaiting requested review from silverkszlo silverkszlo is a code owner

Assignees

No one assigned

Labels

3. to review bug Something isn't working papercut

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Koc @mejo- @max-nextcloud