Skip to content

feat(editor): pass cached team members to Text on mention#2352

Open
mejo- wants to merge 1 commit intomainfrom
feat/mention_team_members
Open

feat(editor): pass cached team members to Text on mention#2352
mejo- wants to merge 1 commit intomainfrom
feat/mention_team_members

Conversation

@mejo-
Copy link
Copy Markdown
Member

@mejo- mejo- commented Mar 19, 2026

Fixes: nextcloud/text#6881

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

Fixes: nextcloud/text#6881

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- self-assigned this Mar 19, 2026
@mejo- mejo- requested a review from max-nextcloud as a code owner March 19, 2026 14:04
@mejo- mejo- added the enhancement New feature or request label Mar 19, 2026
@mejo- mejo- requested a review from silverkszlo as a code owner March 19, 2026 14:04
onMentionSearch(query) {
const users = circlesStore.currentCircleUserMembersSorted
const lowerQuery = query.toLowerCase().trim()
console.debug('members for mention search', users)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be removed?

Copy link
Copy Markdown
Collaborator

@silverkszlo silverkszlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just remove the console.debug line, the rest looks good! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@-mentioning people in a Collective also suggests people who are not part of that Collective

2 participants